Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests using LocalProvider #1141

Closed
psschwei opened this issue Dec 7, 2023 · 2 comments · Fixed by #1212
Closed

Run tests using LocalProvider #1141

psschwei opened this issue Dec 7, 2023 · 2 comments · Fixed by #1212
Assignees
@akihikokuroda
Labels
documentation Improvements or additions to documentation enhancement New feature or request project: client Label to identify features related with client project
Milestone
Q1'24

Comments

@psschwei
Copy link
Collaborator

psschwei commented Dec 7, 2023 •
edited
Loading

What is the expected enhancement?

Now that we have LocalProvider, we should make that the default environment for running tests in the CI. Specifically, https://github.com/Qiskit-Extensions/quantum-serverless/blob/main/.github/workflows/docker-build.yaml could be updated to just run the notebooks (rather than docker build, etc.)

In theory, this means we could also drop docker compose. Longer-term though, we still need full e2e testing on Kubernetes (xref #117 (comment)).
@IceKhan13 IceKhan13 added documentation Improvements or additions to documentation enhancement New feature or request project: client Label to identify features related with client project labels Dec 11, 2023
@IceKhan13 IceKhan13 added this to the Q1'24 milestone Dec 11, 2023
@psschwei psschwei self-assigned this Jan 18, 2024
@psschwei psschwei mentioned this issue Jan 18, 2024
Open
@psschwei psschwei removed their assignment Jan 18, 2024
@psschwei
Copy link
Collaborator Author

In the interim, will note that docs/getting_started/basic/01_running_program.ipynb works fine using LocalProvider

@psschwei psschwei changed the title Make LocalProvider the default local install Run tests using LocalProvider Jan 18, 2024
@akihikokuroda akihikokuroda self-assigned this Feb 6, 2024
@akihikokuroda
Copy link
Collaborator

All notebook samples are using the ServerlessProvider now. Should they be updated to use the LocalProvider in the docs or just modified during the tests on the fly?

@akihikokuroda akihikokuroda mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akihikokuroda akihikokuroda

Labels
documentation Improvements or additions to documentation enhancement New feature or request project: client Label to identify features related with client project
Projects
None yet
Milestone
Q1'24
Development

Successfully merging a pull request may close this issue.

Use LocalProvider for test akihikokuroda/qiskit-serverless
3 participants
@IceKhan13 @akihikokuroda @psschwei