Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Jaeger #280

Closed
IceKhan13 opened this issue Mar 14, 2023 · 10 comments · Fixed by #497
Closed

Deploy Jaeger #280

IceKhan13 opened this issue Mar 14, 2023 · 10 comments · Fixed by #497
Assignees
Labels
enhancement New feature or request project: monitoring Label to identify features related with monitoring
Milestone

Comments

@IceKhan13
Copy link
Member

What is the expected behavior?

Deploy Jaeger to the system.
Expose jaeger to grafana dashboard if possible (maybe avoid Jaeger and emit directly prometheus from opentelemetry spans).

Epic #139

@IceKhan13 IceKhan13 added the enhancement New feature or request label Mar 14, 2023
@IceKhan13 IceKhan13 added this to the 0.2 milestone Mar 14, 2023
@IceKhan13 IceKhan13 changed the title Deploy Jaeger Monitoring: deploy Jaeger Mar 14, 2023
@Tansito Tansito added the project: monitoring Label to identify features related with monitoring label Mar 15, 2023
@Tansito Tansito changed the title Monitoring: deploy Jaeger Deploy Jaeger Mar 15, 2023
@psschwei
Copy link
Collaborator

@IceKhan13 @Tansito

For help with clarifying this task, what was the reason for deploying Jaeger? Was it just for generating trace data (functionality which has been sunset in favor of OpenTelemetry)? Or did we want to use Jaeger for its collector / query tooling? Both?

@Tansito
Copy link
Member

Tansito commented Mar 29, 2023

I don't know if @pacomf has more context maybe. From my conversations with Iskandar I know that we would like to use Jaeger as data source but I don't know If we would have something more in mind, I don't think so. In this case my suggestion would be to start with the simplest configuration and iterate later on if we need advanced things.

@psschwei
Copy link
Collaborator

we would like to use Jaeger as data source

this is the part I'm not 100% clear on: Jaeger uses the OpenTelemetry collector as its source for metrics. Assuming I'm understanding everything correctly, I think it'd be simplest to set up a flow like this:

Pod -> OTel collector -> Prometheus

versus trying to add Jaeger into the stack (either between the collector / prometheus or as its own endpoint).

May make sense to wait on this one until everyone's back and we can discuss...

@Tansito
Copy link
Member

Tansito commented Apr 3, 2023

May make sense to wait on this one until everyone's back and we can discuss...

Sure! Let's do that 😄

@psschwei
Copy link
Collaborator

psschwei commented May 2, 2023

@IceKhan13 now that everyone's back, wanted to follow up on this one to get your thoughts

@IceKhan13
Copy link
Member Author

IceKhan13 commented May 2, 2023

Pod -> OTel collector -> Prometheus

Agree with you @psschwei. We will only need to switch JaegerExporter to OTLPSpanExporter in client.

Only thing matter is an ability to see traces / runtimes of spans :)
I think grafana/promethus duo should have that covered, right? 🤔

@Tansito
Copy link
Member

Tansito commented May 3, 2023

I think grafana/promethus duo should have that covered, right?

I would say yes? I was taking a look to the configuration that Ray has for Metrics using Grafana + prometheus and it seems more than enough:

https://docs.ray.io/en/latest/ray-observability/ray-metrics.html

@akihikokuroda
Copy link
Collaborator

Only thing matter is an ability to see traces / runtimes of spans :)
I think grafana/promethus duo should have that covered, right? 🤔

It doesn't cover the trace span. It covers only metric span.

@akihikokuroda akihikokuroda reopened this Aug 17, 2023
@akihikokuroda
Copy link
Collaborator

akihikokuroda commented Aug 17, 2023

I think we need Jaeger for the distributed trace span in qs-observability for local install

@akihikokuroda
Copy link
Collaborator

I added instructions to install Jaeger in the local install in the README. I close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project: monitoring Label to identify features related with monitoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants