Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual variable support to expr.Var #10923

Closed
Tracked by #10922
jakelishman opened this issue Oct 2, 2023 · 0 comments · Fixed by #10944
Closed
Tracked by #10922

Add manual variable support to expr.Var #10923

jakelishman opened this issue Oct 2, 2023 · 0 comments · Fixed by #10944
Assignees
Milestone

Comments

@jakelishman
Copy link
Member

jakelishman commented Oct 2, 2023

Add support to expr.Var for representing classical variables with some fixed storage location as described in Qiskit/RFCs#50. For the initial pass, we can use some UUID as the backing "data store" link value to use in direct comparisons, which has the advantage of letting QPY round-trip serialisation reproduce the values exactly, whereas requiring singleton object identities for equality has the problem that two circuits serialised separately will end up with spuriously difference variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant