Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCRX, MCRY and MCRZ gates to the circuit library #12048

Closed
ShellyGarion opened this issue Mar 20, 2024 · 1 comment
Closed

Add MCRX, MCRY and MCRZ gates to the circuit library #12048

ShellyGarion opened this issue Mar 20, 2024 · 1 comment
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library type: feature request New feature or request

Comments

@ShellyGarion
Copy link
Member

What should we add?

Currently we have the methods mcrx, mcry and mcrz in the QuantumCircuit class, but they don't appear in the circuit library.
I would suggest to add them to the circuit library as the other multi-controlled gates.

In addition, in order to make a unified API as the other multi-controlled gates, these gates should include the following:

  1. The angles should be of type ParameterValueType (not only float).
  2. Add ctrl_state parameter (like in MCXGate).
  3. The control method of the rx, ry and rz gates, should call the MCRX, MCRY or MCRZ gates respectively (if there are more than two qubits)
@ShellyGarion
Copy link
Member Author

Following the discussion in #12863 (comment), I'll close this issue (and transfer some tasks to #12863)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library type: feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant