Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TwoQubitControlledUDecomposer to the UnitarySynthesis tranpiler pass #13320

Closed
ShellyGarion opened this issue Oct 14, 2024 · 2 comments · Fixed by #13568
Closed

Add TwoQubitControlledUDecomposer to the UnitarySynthesis tranpiler pass #13320

ShellyGarion opened this issue Oct 14, 2024 · 2 comments · Fixed by #13568
Assignees
@ShellyGarion
Labels
type: feature request New feature or request
Milestone
2.0.0

Comments

@ShellyGarion
Copy link
Member

What should we add?

Add the TwoQubitControlledUDecomposer to the UnitarySynthesis tranpiler pass.
This should be the default pass for certain gates (RXX, RYY, RZZ, CRZ, RZX, CRZ, CPhase) with an arbitrary angle.
This depends on PRs #13139 and #13141.
@ShellyGarion ShellyGarion added the type: feature request New feature or request label Oct 14, 2024
This was referenced Oct 15, 2024
Merged
Merged
@ShellyGarion ShellyGarion mentioned this issue Nov 14, 2024
Closed
@ShellyGarion ShellyGarion added this to the 2.0.0 milestone Nov 14, 2024
@yaelbh
Copy link
Contributor

yaelbh commented Nov 14, 2024 •
edited
Loading

@ShellyGarion Can the decomposition result in rzz angle outside of the range [0, pi/2]?
If yes then I suggest to wait until Qiskit/qiskit-ibm-runtime#2043 is merged, to avoid failures of transpiled circuits when executed on IBM devices.

@ShellyGarion
Copy link
Member Author

@ShellyGarion Can the decomposition result in rzz angle outside of the range [0, 2pi]? If yes then I suggest to wait until Qiskit/qiskit-ibm-runtime#2043 is merged, to avoid failures of transpiled circuits when executed on IBM devices.

The synthesis method should provide RZZGates with angles in the range [-pi/2, pi/2]

@yaelbh yaelbh mentioned this issue Nov 14, 2024
Merged
@ShellyGarion ShellyGarion mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShellyGarion ShellyGarion

Labels
type: feature request New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Add 2q fractional gates to the UnitarySynthesis transpiler pass ShellyGarion/qiskit-terra
2 participants
@yaelbh @ShellyGarion