Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FrameChange #3530

Closed
eggerdj opened this issue Dec 2, 2019 · 5 comments
Closed

Rename FrameChange #3530

eggerdj opened this issue Dec 2, 2019 · 5 comments
Assignees
@eggerdj
Labels
mod: pulse Related to the Pulse module on hold Can not fix yet type: discussion type: enhancement It's working, but needs polishing

Comments

@eggerdj
Copy link
Contributor

eggerdj commented Dec 2, 2019

What is the expected enhancement?

In pulse the command FrameChange changes the phase of a pulse channel. A more appropriate name would be either SetPhase or ShiftPhase. SetPhase would be more appropriate if the command sets the phase to a new value while ShiftPhase is more appropriate if the command adds a phase to the current value.
@eggerdj eggerdj self-assigned this Dec 2, 2019
@eggerdj
Copy link
Contributor Author

eggerdj commented Dec 2, 2019

@taalexander and @lcapelluto opinions on the name?

@blakejohnson
Copy link
Contributor

Splitting this out into SetPhase and ShiftPhase makes sense to me.

@taalexander
Copy link
Contributor

Yup. I like both.

@taalexander taalexander added the type: enhancement It's working, but needs polishing label Dec 18, 2019
@lcapelluto lcapelluto added the on hold Can not fix yet label Feb 7, 2020
@lcapelluto
Copy link
Contributor

lcapelluto commented Feb 7, 2020 •
edited
Loading

This can be part of #3750 since there will be renaming/deprecating happening there

@taalexander
Copy link
Contributor

This will be closed by #3750, closing as now a duplicate.

@1ucian0 1ucian0 added the mod: pulse Related to the Pulse module label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eggerdj eggerdj

Labels
mod: pulse Related to the Pulse module on hold Can not fix yet type: discussion type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@1ucian0 @blakejohnson @taalexander @jakelishman @lcapelluto @eggerdj