Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass_manager_drawer requires filename to render #4239

Closed
nonhermitian opened this issue Apr 24, 2020 · 0 comments · Fixed by #4331
Closed

pass_manager_drawer requires filename to render #4239

nonhermitian opened this issue Apr 24, 2020 · 0 comments · Fixed by #4331
Labels
status: pending PR It has one or more PRs pending to solve this issue type: enhancement It's working, but needs polishing

Comments

@nonhermitian
Copy link
Contributor

Information

  • Qiskit Terra version: master
  • Python version:
  • Operating system:

What is the current behavior?

The pass_manager_drawer requires a filename in order to run. However this is not really a requirement of the code itself. Indeed, this works fine:

pass_manager_drawer(pm, '')

Steps to reproduce the problem

What is the expected behavior?

Suggested solutions
@nonhermitian nonhermitian added the bug Something isn't working label Apr 24, 2020
@1ucian0 1ucian0 added type: enhancement It's working, but needs polishing and removed bug Something isn't working labels Apr 28, 2020
@1ucian0 1ucian0 mentioned this issue Apr 28, 2020
Merged
@1ucian0 1ucian0 added the status: pending PR It has one or more PRs pending to solve this issue label Apr 28, 2020
@kdk kdk closed this as completed in #4331 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending PR It has one or more PRs pending to solve this issue type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

missing pass_manager_drawer(..., filename=None) 1ucian0/qiskit-terra
2 participants
@1ucian0 @nonhermitian