Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MSBasisDecomposer from pass manager construction #4698

Closed
kdk opened this issue Jul 14, 2020 · 1 comment · Fixed by #5009
Closed

Remove MSBasisDecomposer from pass manager construction #4698

kdk opened this issue Jul 14, 2020 · 1 comment · Fixed by #5009
Labels
type: enhancement It's working, but needs polishing

Comments

@kdk
Copy link
Member

kdk commented Jul 14, 2020

What is the expected enhancement?

The MSBasisDecomposer pass and ms_basis_swap check in https://github.com/Qiskit/qiskit-terra/blob/41cf87c/qiskit/compiler/transpile.py#L290 were introduced as workarounds to support transpiling to devices with other basis gates. This is now supported directly by the transpiler, so these can be removed. The MSBasisDecomposer pass should be deprecated with a note re-directing to the BasisTranslator. ms_basis_swap can be removed directly.
@kdk kdk added the type: enhancement It's working, but needs polishing label Jul 14, 2020
@enavarro51
Copy link
Contributor

I can take this one.

@enavarro51 enavarro51 mentioned this issue Sep 1, 2020
Merged
@mergify mergify bot closed this as completed in #5009 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate MSBasisDecomposer and remove references in transpiler.py enavarro51/qiskit-terra
2 participants
@kdk @enavarro51