Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VQE should batch per default #8926

Closed
Cryoris opened this issue Oct 17, 2022 · 2 comments · Fixed by #9038
Closed

VQE should batch per default #8926

Cryoris opened this issue Oct 17, 2022 · 2 comments · Fixed by #9038
Labels
bug Something isn't working mod: algorithms Related to the Algorithms module
Milestone

Comments

@Cryoris
Copy link
Contributor

Cryoris commented Oct 17, 2022

What should we add?

The VQE is most commonly used with SPSA or gradient descent, which require 2 or (up to) 2 * num_parameters circuit evaluations per iterations, respectively. Since the new execution model is shifting from using the runtime VQE program to the primitive-based VQE in Terra, we should also enable batching as many circuits per default as possible. Otherwise the standard usage of the VQE will be much slower than necessary (~2 or 2 * num_parameters to slow 😅).

This is something the runtime VQE also did, maybe we can use the same defaults?

@Cryoris Cryoris added the type: feature request New feature or request label Oct 17, 2022
@Cryoris
Copy link
Contributor Author

Cryoris commented Oct 17, 2022

Actually, maybe we can consider this as performance bug and put it in the 0.22.1 release for November 🤔

@Cryoris Cryoris added bug Something isn't working and removed type: feature request New feature or request labels Oct 17, 2022
@Cryoris Cryoris added this to the 0.22.1 milestone Oct 17, 2022
@mtreinish
Copy link
Member

As long as we don't add any new flags or change the api I think it's fine to backport and include this in 0.22.1 as a performance fix.

@woodsp-ibm woodsp-ibm added the mod: algorithms Related to the Algorithms module label Oct 25, 2022
@mergify mergify bot closed this as completed in #9038 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mod: algorithms Related to the Algorithms module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants