Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non existent files in MANIFEST.in #9751

Closed
HuangJunye opened this issue Mar 8, 2023 · 1 comment · Fixed by #9752
Closed

Non existent files in MANIFEST.in #9751

HuangJunye opened this issue Mar 8, 2023 · 1 comment · Fixed by #9752
Labels
bug Something isn't working

Comments

@HuangJunye
Copy link
Collaborator

Environment

  • Qiskit Terra version: fe12c26
  • Python version: 3.10
  • Operating system: macOS Ventura

What is happening?

See these warnings during editable build

      warning: no files found matching 'qiskit/schemas/*.json'
      warning: no files found matching 'qiskit/schemas/examples/*.json'
      warning: no files found matching '*.pyx' under directory 'qiskit'
      warning: no files found matching '*.pxd' under directory 'qiskit'
      warning: no files found matching 'test/python/pickles/*.pickle'

How can we reproduce the issue?

git clone https://github.com/Qiskit/qiskit-terra.git
cd qiskit-terrra
pip install -e .

What should happen?

No warnings

Any suggestions?

Remove these lines in MANIFEST.in

@HuangJunye HuangJunye added the bug Something isn't working label Mar 8, 2023
@HuangJunye
Copy link
Collaborator Author

HuangJunye commented Mar 8, 2023

#6658 removed the deprecated schemas. So the two lines under schemas/ folder can be removed. But I am not so sure about *.pyx, *.pxd and *.pickle

@mergify mergify bot closed this as completed in #9752 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant