Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose vf2_mapping like interface to rustworkx-core #741

Open
mtreinish opened this issue Nov 15, 2022 · 3 comments · May be fixed by #1235
Open

Expose vf2_mapping like interface to rustworkx-core #741

mtreinish opened this issue Nov 15, 2022 · 3 comments · May be fixed by #1235
Labels
enhancement New feature or request

Comments

@mtreinish
Copy link
Member

What is the expected enhancement?

Right now we have the vf2_mapping() function which iteratively returns the isomorphic mappings found by the vf2 algorithm to python space. It would be great to expose this functionality from rustworkx-core too for rust users so given any two generic graph objects we can get an iterator of mappings of node indices between them which are isomorphic. We should look into how we can port the https://github.com/Qiskit/rustworkx/blob/main/src/isomorphism/vf2.rs module into rustworkx-core so we can expose all the vf2 and vf2++ heuristic functionality to rust users too.

@mtreinish mtreinish added the enhancement New feature or request label Nov 15, 2022
@vlvrd
Copy link

vlvrd commented Feb 3, 2023

+1 🙂

@ElePT
Copy link
Contributor

ElePT commented Jun 7, 2024

Interested

@mtreinish
Copy link
Member Author

mtreinish commented Jun 7, 2024

I've been thinking more about this and to get a rustworkx-core interface to start it will be easier to just copy the implementation and leave the rustworkx crate alone. We can worry about de-dpulicating the interface in a followup since there are unknowns about we would interface a rust space iterator with the python side.

@mtreinish mtreinish linked a pull request Jul 30, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants