Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

[discussion] TypeScript or Create react app #15

Closed
quantuminformation opened this issue Oct 6, 2017 · 10 comments
Closed

[discussion] TypeScript or Create react app #15

quantuminformation opened this issue Oct 6, 2017 · 10 comments

Comments

@quantuminformation
Copy link
Contributor

quantuminformation commented Oct 6, 2017

Would TypeScript or Create react app be of interest? With TypeScript you don't need to worry about proptypes.

@quantuminformation
Copy link
Contributor Author

@Qolzam
Copy link
Member

Qolzam commented Oct 6, 2017

I really appreciate your awesome suggestion. Indeed it's what I love to do .First as a .NET fan I greatly agree moving to TS. There are lots of cool features that I love such as typesafe programming, strong-typing, interface, generic stuff and so on. As a result we have cleaner, more reliable and maintainable code. I need to move to TS because this project is bigger than what I thought first so it would be hard to manage in the future.

@toyeebgodo
Copy link

toyeebgodo commented Oct 27, 2017

@quantuminformation , I salute, respect, and admire your level of proficiency. I have an amateur and selfish concern about the introduction of Typescript and the discounting of proptypes even though I have read your well-founded opinions above. I have spent over 1200 hours in the last five months learning Javascript, React, GraphQL, and Apollo full-time and, yet, I am just finding my feet. This project would have been down my alley and I suppose the alley of other intermediate React developers if not for the typescript. It is so sad for an amateur and newbie like me who is on the verge of being bankrupt when it comes to time that I have to go pick up Typescript knowledge in order to understand and work with a React Project. @Qolzam, can I get the old codes in which you used proptypes? Guys, please don't be annoyed at this beginner and amateur who knows not of what he is saying. Please don't hesitate to educate my frustration and naivete.

@Qolzam
Copy link
Member

Qolzam commented Oct 27, 2017

@toyeebgodo Thanks for using React Social Network. I agree with what you said. In the beginning I also had this attitude to follow javascript as whole the things for this project and most of the new users come back to javascript. However as the project growing I couldn't control changing structure and many bugs happened in runtime. Sure there are some good structures to implement javascript project and good design patter not to change the structure. However, for implementing some ideas and to make the project more flexible javascript doesn't make me happy. Moreover developing in typescript is much faster and cleaner than javascript. The next version of this project migrate to typescript with many new awesome stuff, cleaner code, high performance, with AWS and Firebase back-end, easy deploying and CLI to modify project easily. However, this project support .jsx and .js file to so if you want you can add your javascript file easily so Webpack compile it for you. On the whole I have another idea too. I could open another repository for javascript user with tutorial purpose. How about this Idea?

@Qolzam
Copy link
Member

Qolzam commented Oct 27, 2017

@toyeebgodo I've created js-react-social-tutorial repository. If you have any ideas or reporting bug I would be happy sharing with us.

@quantuminformation
Copy link
Contributor Author

@Qolzam I doubt there is much worth in splitting the work over 2 repos, as it will dilute the effort needed to maintain 1 good version.

@toyeebgodo Typescript is simply a superset of javascript, there's not much extra to learn apart from typing.

@Qolzam
Copy link
Member

Qolzam commented Oct 27, 2017

@quantuminformation sure we don't work on two repository. Let me make it clearer that it's only for education or tutorial purpose. And new repository just for the users who are using javascript to run react. As this project migrate to typescript completely I think it's worth at least we have a backup of javascript codes so some users can develop themselves and contribute their ideas. Then they can move to the main project and learn about typescript more. It's like an encouragement in my idea.

@toyeebgodo
Copy link

@Qolzam, I'm so appreciative of your unusual kindness. Thank you so much for adding this repository https://github.com/Qolzam/js-react-social-tutorial for educational reasons; I am in total support. You just made my life easier as a learner. @quantuminformation, I see and empathize with your viewpoint too, however, please allow him keep the JS repo for the sake of all newbies out there . In all seriousness, though, I am going to take up your advice on Typescript being simple to learn and put it on my list of next todos. Thank you so much to both of you.

@toyeebgodo
Copy link

toyeebgodo commented Oct 27, 2017

@Qolzam your point, "However, for implementing some ideas and to make the project more flexible javascript doesn't make me happy. Moreover developing in typescript is much faster and cleaner than javascript. The next version of this project migrate to typescript with many new awesome stuff, cleaner code, high performance, with AWS and Firebase back-end, easy deploying and CLI to modify project easily. " is clearly taken by me.

@quantuminformation, your points are also clearly taken. Muchas gracias.

@Qolzam
Copy link
Member

Qolzam commented Feb 4, 2018

Moved on create-react-app and typescript merged.

@Qolzam Qolzam closed this as completed Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants