New build issue between 1.4.8 -> 1.4.9

[limburgher]

[ 35%] Building CXX object CMakeFiles/QXlsx.dir/source/xlsxworksheet.cpp.o
/usr/lib64/ccache/g++ -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x060600 -DQT_GUI_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQXlsx_EXPORTS -DQXlsx_SHAREDLIB -I/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/redhat-linux-build -I/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx -I/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/redhat-linux-build/QXlsx_autogen/include -I/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/../QXlsx/header -I/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/header -isystem /usr/include/qt6/QtCore -isystem /usr/include/qt6 -isystem /usr/lib64/qt6/mkspecs/linux-g++ -isystem /usr/include/qt6/QtGui/6.7.2 -isystem /usr/include/qt6/QtGui/6.7.2/QtGui -isystem /usr/include/qt6/QtCore/6.7.2 -isystem /usr/include/qt6/QtCore/6.7.2/QtCore -isystem /usr/include/qt6/QtGui -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -std=gnu++17 -fPIC -MD -MT CMakeFiles/QXlsx.dir/source/xlsxworksheet.cpp.o -MF CMakeFiles/QXlsx.dir/source/xlsxworksheet.cpp.o.d -o CMakeFiles/QXlsx.dir/source/xlsxworksheet.cpp.o -c /home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/source/xlsxworksheet.cpp
/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/source/xlsxworkbook.cpp: In member function ‘virtual bool QXlsx::Workbook::loadFromXmlFile(QIODevice*)’:
/home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/source/xlsxworkbook.cpp:610:51: error: ‘QString::QString(const char*)’ is private within this context
610 | if (relationship.target.startsWith("/")) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
In file included from /usr/include/qt6/QtCore/qobject.h:11,
from /usr/include/qt6/QtCore/qiodevice.h:10,
from /usr/include/qt6/QtCore/QIODevice:1,
from /home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/../QXlsx/header/xlsxglobal.h:11,
from /home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/../QXlsx/header/xlsxabstractooxmlfile.h:6,
from /home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/../QXlsx/header/xlsxworkbook.h:6,
from /home/gwyn/fedora/git/QXlsx/QXlsx-1.4.9/QXlsx/source/xlsxworkbook.cpp:3:
/usr/include/qt6/QtCore/qstring.h:979:5: note: declared private here
979 | QString(const char *ch);
| ^~~~~~~
gmake[2]: *** [CMakeFiles/QXlsx.dir/build.make:155: CMakeFiles/QXlsx.dir/source/xlsxworkbook.cpp.o] Error 1

[dantti]

please use master branch

[limburgher]

Is there a set of patches that will apply to 1.4.9 I can use? If not we can wait for 1.4.10.

[FroggyElder]

I changed that line of code to if (relationship.target.startsWith(QLatin1String("/"))) { and it works for now.

[losg66]

I changed that line of code to if (relationship.target.startsWith(QLatin1String("/"))) { and it works for now.

hero!

[limburgher]

Looks good here, thank you!