Remove remaining 3.8 deprecations

Author: QuLogic

doc/api/next_api_changes/removals/28874-ES.rst

@@ -1,3 +1,48 @@
+Passing extra positional arguments to ``Figure.add_axes``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Positional arguments passed to `.Figure.add_axes` other than a rect or an existing
+``Axes`` were previously ignored, and is now an error.
+
+
+Artists explicitly passed in will no longer be filtered by legend() based on their label
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Previously, artists explicitly passed to ``legend(handles=[...])`` are filtered out if
+their label starts with an underscore. This filter is no longer applied; explicitly
+filter out such artists (``[art for art in artists if not
+art.get_label().startswith('_')]``) if necessary.
+
+Note that if no handles are specified at all, then the default still filters out labels
+starting with an underscore.
+
+
+The parameter of ``Annotation.contains`` and ``Legend.contains`` is renamed to *mouseevent*
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+... consistently with `.Artist.contains`.
+
+
+Support for passing the "frac" key in ``annotate(..., arrowprops={"frac": ...})``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+... has been removed.  This key has had no effect since Matplotlib 1.5.
+
+
+Passing non-int or sequence of non-int to ``Table.auto_set_column_width``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Column numbers are ints, and formerly passing any other type was effectively ignored.
+This has now become an error.
+
+
+Widgets
+~~~~~~~
+
+The *visible* attribute getter of ``*Selector`` widgets has been removed; use
+``get_visible`` instead.
+
+
 Auto-closing of figures when switching backend
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -61,6 +106,13 @@ which should cover most use cases.
 ... with no replacement.
 
 
+``TexManager.texcache``
+~~~~~~~~~~~~~~~~~~~~~~~
+
+... is considered private and has been removed. The location of the cache directory is
+clarified in the doc-string.
+
+
 ``cbook`` API changes
 ~~~~~~~~~~~~~~~~~~~~~
 
@@ -74,6 +126,25 @@ now auto-loads numpy arrays. Use ``get_sample_data(..., asfileobj=False)`` inste
 the filename of the data file, which can then be passed to `open`, if desired.
 
 
+Calling ``paths.get_path_collection_extents`` with empty *offsets*
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Calling  `~.get_path_collection_extents` with an empty *offsets* parameter has an
+ambiguous interpretation and is no longer allowed.
+
+
+``bbox.anchored()`` with no explicit container
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Not passing a *container* argument to `.BboxBase.anchored` is no longer supported.
+
+
+``INVALID_NON_AFFINE``, ``INVALID_AFFINE``, ``INVALID`` attributes of ``TransformNode``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+These attributes have been removed.
+
+
 ``axes_grid1`` API changes
 ~~~~~~~~~~~~~~~~~~~~~~~~~~
 

lib/matplotlib/figure.py

@@ -613,22 +613,22 @@ def add_axes(self, *args, **kwargs):
         """
 
         if not len(args) and 'rect' not in kwargs:
-            raise TypeError(
-                "add_axes() missing 1 required positional argument: 'rect'")
+            raise TypeError("add_axes() missing 1 required positional argument: 'rect'")
         elif 'rect' in kwargs:
             if len(args):
-                raise TypeError(
-                    "add_axes() got multiple values for argument 'rect'")
+                raise TypeError("add_axes() got multiple values for argument 'rect'")
             args = (kwargs.pop('rect'), )
+        if len(args) != 1:
+            raise _api.nargs_error("add_axes", 1, len(args))
 
         if isinstance(args[0], Axes):
-            a, *extra_args = args
+            a, = args
             key = a._projection_init
             if a.get_figure(root=False) is not self:
                 raise ValueError(
                     "The Axes must have been created in the present figure")
         else:
-            rect, *extra_args = args
+            rect, = args
             if not np.isfinite(rect).all():
                 raise ValueError(f'all entries in rect must be finite not {rect}')
             projection_class, pkw = self._process_projection_requirements(**kwargs)
@@ -637,11 +637,6 @@ def add_axes(self, *args, **kwargs):
             a = projection_class(self, rect, **pkw)
             key = (projection_class, pkw)
 
-        if extra_args:
-            _api.warn_deprecated(
-                "3.8",
-                name="Passing more than one positional argument to Figure.add_axes",
-                addendum="Any additional positional arguments are currently ignored.")
         return self._add_axes_internal(a, key)
 
     @_docstring.interpd

lib/matplotlib/legend.py

@@ -454,24 +454,10 @@ def __init__(
         self.borderaxespad = mpl._val_or_rc(borderaxespad, 'legend.borderaxespad')
         self.columnspacing = mpl._val_or_rc(columnspacing, 'legend.columnspacing')
         self.shadow = mpl._val_or_rc(shadow, 'legend.shadow')
-        # trim handles and labels if illegal label...
-        _lab, _hand = [], []
-        for label, handle in zip(labels, handles):
-            if isinstance(label, str) and label.startswith('_'):
-                _api.warn_deprecated("3.8", message=(
-                    "An artist whose label starts with an underscore was passed to "
-                    "legend(); such artists will no longer be ignored in the future.  "
-                    "To suppress this warning, explicitly filter out such artists, "
-                    "e.g. with `[art for art in artists if not "
-                    "art.get_label().startswith('_')]`."))
-            else:
-                _lab.append(label)
-                _hand.append(handle)
-        labels, handles = _lab, _hand
 
         if reverse:
-            labels.reverse()
-            handles.reverse()
+            labels = [*reversed(labels)]
+            handles = [*reversed(handles)]
 
         if len(handles) < 2:
             ncols = 1

lib/matplotlib/path.py

@@ -1086,10 +1086,7 @@ def get_path_collection_extents(
     if len(paths) == 0:
         raise ValueError("No paths provided")
     if len(offsets) == 0:
-        _api.warn_deprecated(
-            "3.8", message="Calling get_path_collection_extents() with an"
-            " empty offsets list is deprecated since %(since)s. Support will"
-            " be removed %(removal)s.")
+        raise ValueError("No offsets provided")
     extents, minpos = _path.get_path_collection_extents(
         master_transform, paths, np.atleast_3d(transforms),
         offsets, offset_transform)

lib/matplotlib/table.py

@@ -496,11 +496,7 @@ def auto_set_column_width(self, col):
         """
         col1d = np.atleast_1d(col)
         if not np.issubdtype(col1d.dtype, np.integer):
-            _api.warn_deprecated("3.8", name="col",
-                                 message="%(name)r must be an int or sequence of ints. "
-                                 "Passing other types is deprecated since %(since)s "
-                                 "and will be removed %(removal)s.")
-            return
+            raise TypeError("col must be an int or sequence of ints.")
         for cell in col1d:
             self._autoColumns.append(cell)
 

lib/matplotlib/tests/test_figure.py

@@ -518,12 +518,10 @@ def test_invalid_figure_add_axes():
         fig.add_axes(ax)
 
     fig2.delaxes(ax)
-    with pytest.warns(mpl.MatplotlibDeprecationWarning,
-                      match="Passing more than one positional argument"):
+    with pytest.raises(TypeError, match=r"add_axes\(\) takes 1 positional arguments"):
         fig2.add_axes(ax, "extra positional argument")
 
-    with pytest.warns(mpl.MatplotlibDeprecationWarning,
-                      match="Passing more than one positional argument"):
+    with pytest.raises(TypeError, match=r"add_axes\(\) takes 1 positional arguments"):
         fig.add_axes([0, 0, 1, 1], "extra positional argument")
 
 

lib/matplotlib/tests/test_legend.py

@@ -19,7 +19,7 @@
 import matplotlib.lines as mlines
 from matplotlib.legend_handler import HandlerTuple
 import matplotlib.legend as mlegend
-from matplotlib import _api, rc_context
+from matplotlib import rc_context
 from matplotlib.font_manager import FontProperties
 
 
@@ -138,19 +138,6 @@ def test_various_labels():
     ax.legend(numpoints=1, loc='best')
 
 
-def test_legend_label_with_leading_underscore():
-    """
-    Test that artists with labels starting with an underscore are not added to
-    the legend, and that a warning is issued if one tries to add them
-    explicitly.
-    """
-    fig, ax = plt.subplots()
-    line, = ax.plot([0, 1], label='_foo')
-    with pytest.warns(_api.MatplotlibDeprecationWarning, match="with an underscore"):
-        legend = ax.legend(handles=[line])
-    assert len(legend.legend_handles) == 0
-
-
 @image_comparison(['legend_labels_first.png'], remove_text=True,
                   tol=0.013 if platform.machine() == 'arm64' else 0)
 def test_labels_first():

lib/matplotlib/tests/test_table.py

@@ -2,10 +2,8 @@
 from unittest.mock import Mock
 
 import numpy as np
-import pytest
 
 import matplotlib.pyplot as plt
-import matplotlib as mpl
 from matplotlib.path import Path
 from matplotlib.table import CustomCell, Table
 from matplotlib.testing.decorators import image_comparison, check_figures_equal
@@ -128,10 +126,9 @@ def test_customcell():
 
 @image_comparison(['table_auto_column.png'])
 def test_auto_column():
-    fig = plt.figure()
+    fig, (ax1, ax2, ax3, ax4) = plt.subplots(4, 1)
 
     # iterable list input
-    ax1 = fig.add_subplot(4, 1, 1)
     ax1.axis('off')
     tb1 = ax1.table(
         cellText=[['Fit Text', 2],
@@ -144,7 +141,6 @@ def test_auto_column():
     tb1.auto_set_column_width([-1, 0, 1])
 
     # iterable tuple input
-    ax2 = fig.add_subplot(4, 1, 2)
     ax2.axis('off')
     tb2 = ax2.table(
         cellText=[['Fit Text', 2],
@@ -157,7 +153,6 @@ def test_auto_column():
     tb2.auto_set_column_width((-1, 0, 1))
 
     # 3 single inputs
-    ax3 = fig.add_subplot(4, 1, 3)
     ax3.axis('off')
     tb3 = ax3.table(
         cellText=[['Fit Text', 2],
@@ -171,8 +166,8 @@ def test_auto_column():
     tb3.auto_set_column_width(0)
     tb3.auto_set_column_width(1)
 
-    # 4 non integer iterable input
-    ax4 = fig.add_subplot(4, 1, 4)
+    # 4 this used to test non-integer iterable input, which did nothing, but only
+    # remains to avoid re-generating the test image.
     ax4.axis('off')
     tb4 = ax4.table(
         cellText=[['Fit Text', 2],
@@ -182,12 +177,6 @@ def test_auto_column():
         loc="center")
     tb4.auto_set_font_size(False)
     tb4.set_fontsize(12)
-    with pytest.warns(mpl.MatplotlibDeprecationWarning,
-                      match="'col' must be an int or sequence of ints"):
-        tb4.auto_set_column_width("-101")  # type: ignore [arg-type]
-    with pytest.warns(mpl.MatplotlibDeprecationWarning,
-                      match="'col' must be an int or sequence of ints"):
-        tb4.auto_set_column_width(["-101"])  # type: ignore [list-item]
 
 
 def test_table_cells():

lib/matplotlib/tests/test_widgets.py

@@ -3,7 +3,6 @@
 import operator
 from unittest import mock
 
-import matplotlib as mpl
 from matplotlib.backend_bases import MouseEvent
 import matplotlib.colors as mcolors
 import matplotlib.widgets as widgets
@@ -131,16 +130,6 @@ def test_rectangle_minspan(ax, spancoords, minspanx, x1, minspany, y1):
     assert kwargs == {}
 
 
-def test_deprecation_selector_visible_attribute(ax):
-    tool = widgets.RectangleSelector(ax)
-
-    assert tool.get_visible()
-
-    with pytest.warns(mpl.MatplotlibDeprecationWarning,
-                      match="was deprecated in Matplotlib 3.8"):
-        tool.visible
-
-
 @pytest.mark.parametrize('drag_from_anywhere, new_center',
                          [[True, (60, 75)],
                           [False, (30, 20)]])

lib/matplotlib/texmanager.py

@@ -31,7 +31,7 @@
 import numpy as np
 
 import matplotlib as mpl
-from matplotlib import _api, cbook, dviread
+from matplotlib import cbook, dviread
 
 _log = logging.getLogger(__name__)
 
@@ -63,7 +63,6 @@ class TexManager:
     Repeated calls to this constructor always return the same instance.
     """
 
-    texcache = _api.deprecate_privatize_attribute("3.8")
     _texcache = os.path.join(mpl.get_cachedir(), 'tex.cache')
     _grey_arrayd = {}