Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Update to emsdk/3.1.51 or newer #206

Open
rturrado opened this issue Mar 20, 2024 · 1 comment
Open

[Infra] Update to emsdk/3.1.51 or newer #206

rturrado opened this issue Mar 20, 2024 · 1 comment

Comments

@rturrado
Copy link
Contributor

There is an issue when running the JS code generated from emscripten builds in a Firefox browser that should be fixed by emsdk/3.1.51.

That code modifies Error.stack which is read-only as per spec, but only Firefox follows this spec.
@rturrado
Copy link
Contributor Author

When using emsdk/3.1.51 or newer, we should also get rid of the replace_requires in conan/profiles/{debug,release}, since emsdk/3.1.51 or newer should use nodejs/16.20, instead of nodejs/16.3.

See emsdk/3.1.53 Conan recipe PR and emsdk/3.1.53 Conan recipe issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rturrado