Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text spacing adjustment doesn't work on buttons #90

Closed
Tracked by #72
gabalafou opened this issue May 28, 2024 · 1 comment
Closed
Tracked by #72

Text spacing adjustment doesn't work on buttons #90

gabalafou opened this issue May 28, 2024 · 1 comment

Comments

@gabalafou
Copy link
Contributor

gabalafou commented May 28, 2024

Some components do not respond to user text spacing adjustment: Version switcher trigger button, Search bar trigger button, Search bar input, More dropdown trigger button

@gabalafou gabalafou changed the title Text spacing adjustment doesn't work on buttons [?] Text spacing adjustment doesn't work on buttons May 30, 2024
@gabalafou gabalafou changed the title [?] Text spacing adjustment doesn't work on buttons [>=M] Text spacing adjustment doesn't work on buttons May 30, 2024
@gabalafou gabalafou changed the title [>=M] Text spacing adjustment doesn't work on buttons [M,L] Text spacing adjustment doesn't work on buttons May 30, 2024
@gabalafou gabalafou changed the title [M,L] Text spacing adjustment doesn't work on buttons [?] Text spacing adjustment doesn't work on buttons May 30, 2024
@gabalafou gabalafou moved this from 📬 TODO to Dev in czi-scientific-python 🐍 May 31, 2024
@gabalafou gabalafou moved this from Dev to 📬 TODO in czi-scientific-python 🐍 Jun 4, 2024
@gabalafou gabalafou self-assigned this Aug 8, 2024
@gabalafou gabalafou changed the title [?] Text spacing adjustment doesn't work on buttons Text spacing adjustment doesn't work on buttons Aug 8, 2024
@gabalafou
Copy link
Contributor Author

I think this is actually just an issue with Accessibility Insights and doesn't have anything to do with PST.

Steps I followed:

  1. Visited Technique C36: Allowing for text spacing override
  2. Added the text spacing bookmarklet to my browser
  3. Visited the PyData Sphinx Theme home page
  4. Clicked the bookmarklet
  5. Observed that the text spacing increased everywhere, including in the buttons, where it previously did not with the Accessibility Insights visual helper

In the following screenshot, notice that the text spacing has increased in the version switcher opener button, the open version switcher menu, the "more" dropdown button, and the search opener button:

I also tested the home page in Polypane and got the same conforming result.

Therefore, I believe there's nothing to do with this issue, and so I am closing it.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to 💪🏾 Done in czi-scientific-python 🐍 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants