Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team update - Oct 05, 2022 #161

Closed
trallard opened this issue Oct 5, 2022 · 7 comments
Closed

Team update - Oct 05, 2022 #161

trallard opened this issue Oct 5, 2022 · 7 comments
Labels
type: internal-pm Items related to how we manage the project internally type: team-update

Comments

@trallard
Copy link
Member

trallard commented Oct 5, 2022

This is a @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.

Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with foo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...

**My availability for next week**
- I'll be off on foo day...

**Important items for discussion 💬**
- I have a question about goal <link-to-goal>
- Can @foo give a comment on issue #NN ?
- I opened #NN for discussion, please chime in
- I need to discuss foo

🔍 Needs Triage

The Needs Triage issues require an initial assessment and labeling.

No issues need triage! 🎉

🎯 Project boards

Please make sure the boards reflect the current status of the project.

Jupyter a11y grant project

@trallard trallard added type: internal-pm Items related to how we manage the project internally type: team-update labels Oct 5, 2022
@steff456
Copy link

steff456 commented Oct 6, 2022

Updates from last week ✔️

  • I worked in the accessibility pygments package
    • Created a demo html to see the themes in multiple languages at a time
    • Made a major refactoring in order to add themes easily
    • Created a contribution guide

Challenges I faced and things I'd like assistance with 🙏

  • I'm ok

My availability for next week

  • I'll be here

Important items for discussion 💬

  • I don't have anything important for today

@isabela-pf
Copy link
Contributor

Thanks I'd like to give 🙌

Updates from last week ✔️

  • I don't think I made substantial progress on any of the main things on my plate yet.
  • I set some next steps for myself with 200% zoom in slack.
  • I reviewed and merged my keyboard navigation workshop PR since there haven't been any updates. Hoping to give it a test soon.

Challenges I faced and things I'd like assistance with 🙏

My availability for next week

  • I'll be here all week.

Important items for discussion 💬

  • I don't think there's anything we can discuss.

@trallard
Copy link
Member Author

trallard commented Oct 6, 2022

@kulsoomzahra
- demo of solution Quansight-Labs/jupyterlab-accessible-themes#37


@isabela-pf
- Merged the keyboard navigation workshop
- Zoom: Command palette and Tab to be added
- Actions: will work on typing the proposals for access


@steff456
- completed the first iteration of the a11y-pygments package
- will work on the release on pypi and conda


@gabalafou
- rethinking testing and reporting
- as we are working on fixing issues -> e.g. colour contrast -> work on figure out to add that as a test (manual + automated where possible)
- can we create "personas"? https://alphagov.github.io/accessibility-personas/setup/chromebook.html#setting-up-personas-on-chromebooks

@gabalafou
Copy link
Contributor

Sorry I'm late on this. I moved some meetings around without leaving myself time to write my update before the meeting.

Thanks I'd like to give 🙌

The thing about accessibility work is that every little bit helps. You don’t have to address every consideration I have in this post in one big, sweeping change. Instead, try picking one thing to focus on, and build from there.

Updates from last week ✔️

  • I spent about half my time working on WCAG 1.4.10, thinking about ways to possibly meet it, providing feedback on Isabela's proposals.
  • The other half of my time I spent thinking hard about the testing repo and what purpose it serves. I've been wanting to work towards something that can be considered a full end-to-end product, and I have an idea, which I will add in a later comment to this issue.

Challenges I faced and things I'd like assistance with 🙏

  • I've once again lost sight of what the purpose of the testing repo is. I need to be given the elevator pitch again.

My availability for next week

  • I'll be here.

@gabalafou
Copy link
Contributor

@kulsoomzahra I’m not sure if you saw this in the team meeting, but I discovered that the design we were discussing for the running tabs panel has already been implemented in Notebook 7. To see it, follow the Binder link at the Discourse thread announcing the Notebook 7 pre-release. You can then take a look at the Running tab. :)

@gabalafou
Copy link
Contributor

gabalafou commented Oct 7, 2022

@trallard, here's my follow up to our conversation, my proposal for the rest of this month. Here's what I would like my deliverable for the end of this month to be. I want to create a working service such that when I open a PR that fixes an accessibility issue on JupyterLab, I can ask the service to run a set of tests and post a comment on the PR that shows 1 failing test before the PR and all tests passing after the PR.

For a first example, I will use my tab trap test plus fix. I will write up a document (in markdown) explaining this test and how to perform it manually. I will set up the testing service so that it can run only tests marked as regression tests. I will add a feature to the testing service that will allow it to perform a before/after comparison, highlighting failed tests and providing links to the markdown documentation for each failed test.

In the end, my demo of this deliverable will be a PR on my fork of JupyterLab. On that PR, you will see a comment from the testing service that shows one test (tab trap) failing before the PR, and passing after the PR. In that comment, you will get a link to the markdown document that explains the failing tab trap test.

To recap, here are the components of this deliverable:

  • Add markdown doc for the one tab trap test. This will demonstrate a system that builds upon Isabela's test script template to create individual markdown files for each test. The ACT Rules collection is somewhat similar to what I want to build towards, but instead of rules, we'll be documenting actual tests that can be performed manually and in some cases automatically.
  • Add ability to build JupyterLab from source and run tests against it.
  • Add ability to run a subset of tests marked as regressions.
  • Add ability to take a JupyterLab PR (whether on a fork or on the main repo) as input, and produce as output a comment on that PR that compares a regression test run on that PR's parent branch versus the PR's branch, providing for each test failure a link to that test's documentation in our GitHub testing repo.

As far as the end user (in this case a dev or reviewer) is concerned the only UI for this deliverable is on the PR. It will look something like the following.


PR #X on gabalafou:jupyterlab:fix-tab-trap-branch

comment (me): @jupyter-a11y-testing please run before/after

comment (jupyter-a11y-testing):
Somebody asked the jupyter-a11y-testing robot to run the accessibility regressions tests (will link to document explaining what the accessibility regressions tests are and are not) against JupyterLab before and after this PR is applied. Here is the result.

Before this PR: 1 failing test

  • No tab traps in initial app view (will link to the doc for this test)

After this PR: No failing tests

@gabalafou
Copy link
Contributor

@trallard to respond specifically to your question about using personas, I have to think some more about it. The blog post frames the personas as being useful in the design process, doesn't say anything about using them in the testing process, but maybe there is a way to somehow incorporate the general idea into a testing framework. I'll have to think about that some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal-pm Items related to how we manage the project internally type: team-update
Projects
Status: Done 💪🏾
Development

No branches or pull requests

4 participants