Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Labs and Consulting blog RSS feed generation is broken, and disabled #403

Closed
bskinn opened this issue Aug 2, 2022 · 5 comments
Closed
Labels
area: react labs focus 🧪 Prioritized or work by Labs labs 🔭 Items related to the Labs website priority: high 🌋 High-priority issue type: bug 🐛 Something isn't working

Comments

@bskinn
Copy link
Contributor

bskinn commented Aug 2, 2022

What site is this for?

Quansight Labs
Quansight Consulting

Expected behavior

RSS feed generation for the blog posts for both sites should occur on every build.

Actual behavior

Using the Labs site as an example:

The RSS feed is not generated, as the function call to generate it is commented out.

Upon testing, uncommenting the generation function causes the Labs site build to break.

This needs to be fixed. We will have to decide whether we also want an RSS feed generated for the LLC blog, as part of #396. Yes, we desire this for Consulting blog also.

How to Reproduce the problem?

No response

Anything else?

No response

@bskinn
Copy link
Contributor Author

bskinn commented Sep 19, 2022

Added the LLC label since this will apply to LLC blog after #396 is complete.

@bskinn bskinn added the labs focus 🧪 Prioritized or work by Labs label May 30, 2023
@bskinn bskinn changed the title [BUG] - Labs blog RSS feed generation is broken, and disabled [BUG] - Labs and Consulting blog RSS feed generation is broken, and disabled Jun 2, 2023
@bskinn
Copy link
Contributor Author

bskinn commented Jun 9, 2023

#739 is addressing the broken RSS feed for Labs.

tl;dr -- it was likely never actually broken. It was just that a series of events led us to believe that it was. See #739 for more details.


Further discussion on the approach to expanding implementation of the RSS feed for Consulting blog, prior to actually starting work, should take place here.

From #739 -- @bskinn -- #739 (comment):

I believe the big question is whether it would be a good idea to refactor the RSS code to a common location in /libs/shared, or to implement it separately for Consulting vs Labs. This'll depend on whether there's enough commonality between the two sites.

It may be a good idea to create a new event for the discussion around a Consulting RSS implementation, so as to retain the history implicit in this issue's current title and discussion.

@bskinn
Copy link
Contributor Author

bskinn commented Jun 15, 2023

I've created #741 to track any discussion on RSS for the Consulting blog, and am closing this one after the merge of #739.

@bskinn bskinn closed this as completed Jun 15, 2023
@kalvdans
Copy link

Sorry for posting a question here, but what is the URL to the rss feed of the Labs blog? There's no autodiscover tag on https://labs.quansight.org/blog .

@bskinn
Copy link
Contributor Author

bskinn commented Nov 14, 2023

No problem at all, @kalvdans! That autodiscover tag sounds like something we should add, as well as a direct RSS link in the footer, probably.

The feed is at https://labs.quansight.org/rss.xml.

Thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: react labs focus 🧪 Prioritized or work by Labs labs 🔭 Items related to the Labs website priority: high 🌋 High-priority issue type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants