Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ipython config within jupyterlab to docker image with more robust jupyterlab ssh tests #1143

Merged
merged 13 commits into from
Mar 21, 2022

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Mar 4, 2022

Closes #1157

This PR serves a few purposes. All with the goal of making the docker images simpler (only has installed packages not configuration).

  • reinstating the /etc/skel work that Dan added earlier to jupyterhub/qhub
  • having the jupyter/ipython configuration managed by qhub (ties into the work that vini did in Adjust Idle culler settings and add internal culling #1133)
  • removing the /etc/profile magic from the docker image which lead to weird ssh behavior with jupyterhub_ssh. This will fix the jupyterhub_ssh test and allow us to test the terminal behavior and user environment better.

@costrouc costrouc force-pushed the fix-simplify-docker branch from ff746f6 to 69a40f3 Compare March 4, 2022 04:49
@costrouc
Copy link
Member Author

costrouc commented Mar 4, 2022

Need to test on a local cluster

@costrouc costrouc changed the title Move ipython config within jupyterlab docker image Move ipython config within jupyterlab to docker image with more robust jupyterlab ssh tests Mar 4, 2022
@costrouc
Copy link
Member Author

costrouc commented Mar 4, 2022

I've made the jupyterhub_ssh tests quite strict to ensure that the user environment it setup properly. Make take a few tries to get all the tests passing. I also changed the test username to be a complex example to test how jupyterlab handles this example-user+new1@example.com.

@viniciusdc
Copy link
Contributor

Hi @costrouc I will add this to v0.4.x milestone, is it okay for you?

@costrouc
Copy link
Member Author

costrouc commented Mar 7, 2022

@costrouc costrouc force-pushed the fix-simplify-docker branch from 6f41de7 to 03b7b72 Compare March 18, 2022 17:32
@costrouc
Copy link
Member Author

@viniciusdc this would be ready for review now that 0.4 has been released

@costrouc costrouc requested a review from viniciusdc March 18, 2022 18:20
@viniciusdc
Copy link
Contributor

@viniciusdc this would be ready for review now that 0.4 has been released

I will review it thanks @costrouc, as I will deploy it to test the PS1 features and check the configmaps directly, I should finish it by next Monday.

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to check all configmaps were present and working. The skel configs were propagated and I was able to validate the pytests as well.

@costrouc
Copy link
Member Author

I updated to the latest in main and if that passes I will merge.

@costrouc costrouc merged commit ec0a9ce into main Mar 21, 2022
@costrouc costrouc deleted the fix-simplify-docker branch March 21, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Cleanup terminal prompt
2 participants