Upgrade mrparkers to 3.7.0 #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I repeatedly saw problems when trying to deploy locally with minikube.
The qhub keycloak realm seemed to fail to be created, causing the subsequent keycloak config to fail ("Realm not found")
This PR seems to make things better, although I'm not sure of the root cause. I also think related Terraform problems can still occur later on in non-keycloak components, but we will have to keep an eye on that separately.
minikube v1.25.2 on Ubuntu 20.04 (amd64)
Using the docker driver
Kubernetes v1.23.3 on Docker 20.10.12 ...
All in a Parallels VM on Mac
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?