Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for general node upgrade #1246

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Add docs for general node upgrade #1246

merged 4 commits into from
Apr 29, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves #1124

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Add an FAQ on the possibility of an inplace upgrade to the general node instance type.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

Comment on lines 107 to 108
| AWS | - |
| Azure | - |
Copy link
Member Author

@iameskild iameskild Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have time this week, I will try to test node upgrades for these two providers as well.

@magsol magsol added this to the Release v0.4.1 milestone Apr 26, 2022
@costrouc costrouc merged commit f26156f into main Apr 29, 2022
@costrouc costrouc deleted the docs-1124-eae branch April 29, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants