Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Container Registry #741

Merged
merged 6 commits into from
Aug 9, 2021
Merged

External Container Registry #741

merged 6 commits into from
Aug 9, 2021

Conversation

danlester
Copy link
Contributor

Allow user to specify a private external AWS ECR as a replacement for Docker Hub for selected images, on any cloud.
Add to qhub-config.yaml:

external_container_reg:
  enabled: true
  access_key_id: <AWS access key id>
  secret_access_key: <AWS secret key>
  extcr_account: 892486800165
  extcr_region: eu-west-2

If this section is completely omitted, qhub should never complain (and assume enabled=false).

@danlester danlester requested a review from costrouc July 23, 2021 15:48
@danlester
Copy link
Contributor Author

Merging now to ensure my codebase doesn't diverge too much...

@danlester danlester merged commit 528bb85 into main Aug 9, 2021
@danlester danlester deleted the extcr branch August 9, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant