Update remove_existing_renders to only delete qhub related files/directories
#800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 2, 2021 09:44
costrouc
requested changes
Sep 3, 2021
|
|
||
| for deletable_dir in deletable_dirs: | ||
| deletable_dir = dest_repo_dir / deletable_dir | ||
| if deletable_dir.exists(): |
There was a problem hiding this comment.
Ah. Sorry I shouldn't have mentioned that os.remove and shutil.rmtree shouldn't be used. I meant that more generally that long term i'd like to minimize the number of times that we make this call! Since it's a scary operation.
I'm fine with using shutil.rmtree here and I think that will dramatically reduce the code here.T his should remove all the walking in the code.
Also deletable_dirs should include .gitlab-ci.yml.
There was a problem hiding this comment.
Got it! Thanks for the feedback. And I agree, using shutil.rmtree would be preferred.
costrouc
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Thanks @iameskild this looks great to me and worked when I tested it locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #767
The approach taken will only remove files/directories found in the
deletable_dirslist. In the linked issue, the acceptance criteria specifies removing allos.removeandshutil.rmtreelogic so my current solution employsPathobject methods (which essentially do the same thing).I have also added a
verbosityflag (currently set to0- none) if and when we would like to output the list of files/directories being deleted.All feedback is welcome :)