-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Switch to pydata sphinx theme #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @tylerpotts . We definitely needed this. Just some missing content and a commented out section that needs to be removed.
@costrouc Thanks for the review! I think I prematurely tagged you on this. I'm still working on getting the functionality/flow of the docs working and then I'll go back and add content to the pages you tagged. Will be working more on this Monday I'll take you off as a revier for now, and add you back once it's ready to review again |
bfcfe84
to
a2d5b9c
Compare
@costrouc This is ready to review. We can discuss if the version on the bottom right is still necessary. Definitely more that can be done here, but I think this is in a good place to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge the source blocks but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylerpotts the docs/requirements.txt
need to be updated to include pydata_sphinx_theme
@costrouc It's already in the requirements: Not sure how it originally got there, but that's why it's not showing in the PR |
Related to #759
This PR will change the docs to use the pydata sphinx theme
Remaining tasks: