Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specialize evalbase based on type of breaks array #27

Open
sglyon opened this issue Mar 15, 2017 · 0 comments
Open

specialize evalbase based on type of breaks array #27

sglyon opened this issue Mar 15, 2017 · 0 comments

Comments

@sglyon
Copy link
Member

sglyon commented Mar 15, 2017

Right now our evalbase method for SplineParams and LinParams doesn't utilize the information in the type parameter (which specifies the type of the breaks <: AbstractVector)

Cases where breaks::Range could be sped up significantly in at least two places:

  1. computing the indices specifying the lower boundary on the breaks. This could be simplified into rescaling the input point to live on 1:length(breaks) and then adjusting the endpoints
  2. Computing the actual basis matrix: here we wouldn't need to do lookups of adjacent points in breaks and dividing by their difference -- that difference is the same constant for all pairs of adjacent breaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant