-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update discrete rv code #398
Comments
My only concern is seeding of the random number generator. One has to set a seed within a jit function, so np.random.seed(0)
qe.random.draw(cdf, 10) does not work. I am fine with removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that #397 is merged, I propose that we remove the
DiscreteRV
classhttps://github.com/QuantEcon/QuantEcon.py/blob/master/quantecon/discrete_rv.py
Not a good idea to have two sets of code for doing the same thing.
The lectures will all need to be updated accordingly, but this is a good thing, since it encourages our transition to exploiting jit compilation more thoroughly.
CC @oyamad @mmcky
The text was updated successfully, but these errors were encountered: