You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not a good idea to have two sets of code for doing the same thing.
The lectures will all need to be updated accordingly, but this is a good thing, since it encourages our transition to exploiting jit compilation more thoroughly.
My only concern is seeding of the random number generator.
One has to set a seed within a jit function, so
np.random.seed(0)
qe.random.draw(cdf, 10)
does not work.
I am fine with removing DiscreteRV (I never used it in my code), but just pointing out these are not exactly the same; one is for general use and the other for use within a jit function.
Now that #397 is merged, I propose that we remove the
DiscreteRV
classhttps://github.com/QuantEcon/QuantEcon.py/blob/master/quantecon/discrete_rv.py
Not a good idea to have two sets of code for doing the same thing.
The lectures will all need to be updated accordingly, but this is a good thing, since it encourages our transition to exploiting jit compilation more thoroughly.
CC @oyamad @mmcky
The text was updated successfully, but these errors were encountered: