Skip to content
This repository has been archived by the owner on Jun 4, 2020. It is now read-only.

use quantecon's rank_size_plot #38

Closed
jstac opened this issue Dec 8, 2019 · 3 comments · Fixed by QuantEcon/lecture-python#139
Closed

use quantecon's rank_size_plot #38

jstac opened this issue Dec 8, 2019 · 3 comments · Fixed by QuantEcon/lecture-python#139
Assignees
Labels
good first issue Good for newcomers

Comments

@jstac
Copy link
Contributor

jstac commented Dec 8, 2019

Do a search for all rst files that contain rank_size.

Replace the rank size plotting code there with the code in this PR as soon as it is merged.

@Harveyt47 Harveyt47 transferred this issue from QuantEcon/lecture-source-py Apr 23, 2020
@Harveyt47
Copy link
Member

Harveyt47 commented Apr 23, 2020

Hi @jstac I can only see rank size plots in the following lectures.

Heavy-Tailed Distributions this lecture uses log on the variables then plots those log variables while the PR you link uses ax.loglog().

Wealth Distribution Dynamics this lecture uses log on the variables then plots those log variables while the PR you link uses ax.loglog()

Kesten Processes and Firm Dynamics
This lecture uses the QuantEcon.py library

Do you prefer the use of ax.loglog() over log on the variables?

@Harveyt47 Harveyt47 self-assigned this Apr 23, 2020
@Harveyt47 Harveyt47 added the good first issue Good for newcomers label Apr 23, 2020
@jstac
Copy link
Contributor Author

jstac commented Apr 25, 2020

Yes, thanks @Harveyt47, the first two should be changed to use the quantecon Python library.

In each case, the code that generates a rank size plot from the data should be removed and the function qe.rank_size_plot should be used -- the data should be passed directly to this function. When the exercise is stated, the reader should be informed of the existence of this library function.

@Harveyt47
Copy link
Member

Thanks @jstac I see now.

  1. I will add a reference of the functions existance as well as a link to the documentation to the exercise question.

  2. I will also remove the code of the function from the answer and call the function via qe.rank_size_plot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants