-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memestra doesn't work if you're using __init__ imports #12
Comments
This looks like a case where we want the import to be recursive, right? If that's so it would be good to have the generic opt-in recursive import mechanism, then use it for |
Yeah, so I thought, but it's not working with the recursion I implemented here #9, that's why I opened an issue to keep track and explore it later. :) |
Yeah, I think what I meant here was that I was having a problem with relative imports, that are still not working. Maybe we should do this before tagging a release. I can give it a try :) |
Sure, go ahead!
|
I think it'd be better to merge your PR first? |
I think it's better to merge my PR first, but it shouldn't prevent you from starting to work on that issue :-) |
I found a case where memestra doesn't work, but I suppose we want it to work:
If you're importing something from init like in here:
https://github.com/numpy/numpy/blob/41e254f96e8d5bd558d2edbf8b198eb4143e8b74/numpy/__init__.py#L155
for example, memestra won't return anything.
A reproducible example of what I mean would be running a file
init_test.py
with the commandmemestra init_test.py --decorator=decoratortest.deprecated
that contains:in memestra home and adding this line
from some_module import foo
to the__init__.py
intests/misc
.The text was updated successfully, but these errors were encountered: