Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memestra doesn't work if you're using __init__ imports #12

Open
marimeireles opened this issue May 22, 2020 · 6 comments
Open

Memestra doesn't work if you're using __init__ imports #12

marimeireles opened this issue May 22, 2020 · 6 comments

Comments

@marimeireles
Copy link
Contributor

I found a case where memestra doesn't work, but I suppose we want it to work:

If you're importing something from init like in here:

https://github.com/numpy/numpy/blob/41e254f96e8d5bd558d2edbf8b198eb4143e8b74/numpy/__init__.py#L155

for example, memestra won't return anything.

A reproducible example of what I mean would be running a file init_test.py with the command memestra init_test.py --decorator=decoratortest.deprecated that contains:

from tests.misc import foo

foo()

in memestra home and adding this line from some_module import foo to the __init__.py in tests/misc.

@serge-sans-paille
Copy link
Collaborator

This looks like a case where we want the import to be recursive, right? If that's so it would be good to have the generic opt-in recursive import mechanism, then use it for __init__.py

@marimeireles
Copy link
Contributor Author

marimeireles commented May 27, 2020

Yeah, so I thought, but it's not working with the recursion I implemented here #9, that's why I opened an issue to keep track and explore it later. :)
Please let me know if I can assist you with anything regarding these recursion issues.

@marimeireles
Copy link
Contributor Author

Yeah, I think what I meant here was that I was having a problem with relative imports, that are still not working. Maybe we should do this before tagging a release. I can give it a try :)

@serge-sans-paille
Copy link
Collaborator

serge-sans-paille commented Jun 11, 2020 via email

@marimeireles
Copy link
Contributor Author

I think it'd be better to merge your PR first?
Or you don't think it'd make much difference?

@serge-sans-paille
Copy link
Collaborator

I think it's better to merge my PR first, but it shouldn't prevent you from starting to work on that issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants