We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe that inv_gaussian_log_rowwise_gradient_hessian is incorrect, and it should instead be
inv_gaussian_log_rowwise_gradient_hessian
@@ -276,12 +276,12 @@ def inv_gaussian_log_rowwise_gradient_hessian( inv_mu = 1 / mu[i] inv_mu2 = inv_mu ** 2 - gradient_rows_out[i] = 2 * weights[i] * (inv_mu - y[i] * inv_mu2) - hessian_rows_out[i] = 2 * weights[i] * (inv_mu - 2 * y[i] * inv_mu2) + gradient_rows_out[i] = weights[i] * (y[i] * inv_mu2 - inv_mu) + hessian_rows_out[i] = weights[i] * (2 * y[i] * inv_mu2 - inv_mu)
@lbittarello, let me know if you agree.
Originally posted by @stanmart in #889 (comment)
The text was updated successfully, but these errors were encountered:
Yes, the signs should be flipped.
Sorry, something went wrong.
TweedieDistribution._rowwise_gradient_hessian
Successfully merging a pull request may close this issue.
I believe that
inv_gaussian_log_rowwise_gradient_hessian
is incorrect, and it should instead be@lbittarello, let me know if you agree.
Originally posted by @stanmart in #889 (comment)
The text was updated successfully, but these errors were encountered: