Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbid numpy 2.0 #12

Merged
merged 14 commits into from
Jun 19, 2024
Merged

forbid numpy 2.0 #12

merged 14 commits into from
Jun 19, 2024

Conversation

Krastanov
Copy link
Member

fixes #11

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7e1751f) to head (01c0812).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            7         7           
=========================================
  Hits             7         7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov
Copy link
Member Author

finally... jeez, pip is so bad at version resolution.

It seems pip can not be used to force a particular version of a dependency during the build phase, which is why we had to fork ldpc for now.

@Krastanov Krastanov merged commit 00cc97a into master Jun 19, 2024
7 of 11 checks passed
@Krastanov Krastanov deleted the numpy2 branch June 19, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ldpc initialization error due to numpy data type
1 participant