You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To calculate the volume integral term, integrate function should be used always. In case the integral is to be evaluated by Lobatto quadrature using N_LGL number of quadrature points, the algorithm can be made faster. However, this needs to be within a tested integrate() function. This is not the case.
Code duplication needs to be avoided to prevent bugs.
Also the when N_LGL != N_quad, the code is not vectorized. This too needs to be fixed.
The text was updated successfully, but these errors were encountered:
Commit : 5a0b743
Issue
To calculate the volume integral term, integrate function should be used always. In case the integral is to be evaluated by Lobatto quadrature using N_LGL number of quadrature points, the algorithm can be made faster. However, this needs to be within a tested
integrate()
function. This is not the case.Code duplication needs to be avoided to prevent bugs.
Also the when N_LGL != N_quad, the code is not vectorized. This too needs to be fixed.
The text was updated successfully, but these errors were encountered: