Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume integral term not using integrate() function #51

Open
Balavarun5 opened this issue Oct 7, 2017 · 1 comment
Open

Volume integral term not using integrate() function #51

Balavarun5 opened this issue Oct 7, 2017 · 1 comment
Assignees
Labels

Comments

@Balavarun5
Copy link
Contributor

Balavarun5 commented Oct 7, 2017

Commit : 5a0b743

Issue

To calculate the volume integral term, integrate function should be used always. In case the integral is to be evaluated by Lobatto quadrature using N_LGL number of quadrature points, the algorithm can be made faster. However, this needs to be within a tested integrate() function. This is not the case.

Code duplication needs to be avoided to prevent bugs.

Also the when N_LGL != N_quad, the code is not vectorized. This too needs to be fixed.

@mchandra
Copy link
Contributor

mchandra commented Oct 7, 2017

Also the when N_LGL != N_quad, the code is not vectorized. This too needs to be fixed.

Open a separate issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants