updater: cleanup

move package manager logic to subclasses

(cherry picked from commit 528a5d0)

vmupdate/agent/source/apt/apt_cli.py

@@ -91,7 +91,9 @@ def get_action(self, remove_obsolete: bool) -> List[str]:
         """
         Return command `upgrade` or `dist-upgrade` if `remove_obsolete`.
         """
-        return ["dist-upgrade"] if remove_obsolete else ["upgrade"]
+        result = ["-y"]
+        result += ["dist-upgrade"] if remove_obsolete else ["upgrade"]
+        return result
 
     def clean(self) -> int:
         """

vmupdate/agent/source/common/package_manager.py

@@ -267,17 +267,15 @@ def get_packages(self) -> Dict[str, List[str]]:
 
     def get_action(self, remove_obsolete: bool) -> List[str]:
         """
-        Return command for upgrade or upgrade with removing obsolete packages.
+        Return command and options for upgrade with optional removing obsoletes.
         """
         raise NotImplementedError()
 
     def upgrade_internal(self, remove_obsolete: bool) -> ProcessResult:
         """
         Just run upgrade via CLI.
         """
-        cmd = [self.package_manager,
-               "--noconfirm" if self.package_manager == "pacman" else "-y",
-               *self.get_action(remove_obsolete)]
+        cmd = [self.package_manager, *self.get_action(remove_obsolete)]
 
         return self.run_cmd(cmd)
 

vmupdate/agent/source/dnf/dnf_cli.py

@@ -95,8 +95,8 @@ def get_action(self, remove_obsolete) -> List[str]:
         Disable or enforce obsolete flag in dnf/yum.
         """
         if remove_obsolete:
-            return ["--obsoletes", "upgrade"]
-        return ["--setopt=obsoletes=0",
+            return ["-y", "--obsoletes", "upgrade"]
+        return ["-y", "--setopt=obsoletes=0",
                 "upgrade" if self.package_manager == "dnf" else "update"]
 
     def clean(self) -> int:

vmupdate/agent/source/pacman/pacman_cli.py

@@ -65,7 +65,7 @@ def get_action(self, remove_obsolete) -> List[str]:
         """
         Pacman will handle obsoletions itself
         """
-        return ["-Syu"]
+        return ["--noconfirm", "-Syu"]
 
     def clean(self) -> int:
         """