Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out qubesbuilder.CopyTemplateBack #7126

Closed
DemiMarie opened this issue Dec 16, 2021 · 2 comments
Closed

Rip out qubesbuilder.CopyTemplateBack #7126

DemiMarie opened this issue Dec 16, 2021 · 2 comments
Labels
C: builder Qubes Builder P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: declined Resolution: While a legitimate bug or proposal, it has been decided that no action will be taken. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@DemiMarie
Copy link

How to file a helpful issue

The problem you're addressing (if any)

qubesbuilder.CopyTemplateBack is unnecessary attack surface.

The solution you'd like

Replace it by redirecting the build’s stdout to stderr and returning the built image via stdout.

The value to a user, and who that user might be

Developers will benefit because building the template in a disposable qube will be easier to set up.

@DemiMarie DemiMarie added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Dec 16, 2021
@andrewdavidwong andrewdavidwong added the C: builder Qubes Builder label Dec 16, 2021
@andrewdavidwong andrewdavidwong added this to the Non-release milestone Dec 16, 2021
@andrewdavidwong andrewdavidwong removed this from the Non-release milestone Aug 13, 2023
@marmarek
Copy link
Member

That's part of builderv1 which doesn't get feature development anymore.

@marmarek marmarek added the R: declined Resolution: While a legitimate bug or proposal, it has been decided that no action will be taken. label Nov 24, 2024
Copy link

This issue has been closed as "declined." This means that the issue describes a legitimate bug (in the case of bug reports) or proposal (in the case of enhancements and tasks), and it is actionable, at least in principle. Nonetheless, it has been decided that no action will be taken on this issue. Here are some examples of reasons why an issue may be declined:

  • No solution can be found.
  • The proposed action is not possible.
  • The proposed action would weaken security to an unacceptable degree.
  • The proposed action would be too costly (in time, money, or other resources) relative to the benefits it would provide.
  • The proposed action would make some things better while making other things worse, and the trade-off is not worthwhile.

These are just general examples. If the specific reason for this particular issue being declined has not already been provided, please feel free to leave a comment below asking for an explanation.

We respect the time and effort you have taken to file this issue, and we understand that this outcome may be unsatisfying. Please accept our sincere apologies and know that we greatly value your participation and membership in the Qubes community.

If anyone reading this believes that this issue was closed in error or that the resolution of "declined" is not accurate, please leave a comment below saying so, and the Qubes team will review this issue again. For more information, see How issues get closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: builder Qubes Builder P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: declined Resolution: While a legitimate bug or proposal, it has been decided that no action will be taken. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants
@marmarek @DemiMarie @andrewdavidwong and others