-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qvm-open-in-vm text filter does not match dispvm-names #7466
Comments
Still handled this way in Q4.2 |
Seems like this has been silently fixed and now both are matched (the template and a new dispvm from the template). It does not match existing dispVMs based on that template (which may be useful, but given it is named dispXYZ you would not necessarily expect it is matched. As I suggested two years ago: |
@rwiesbach: If I understand you correctly, the main request in this issue has been fulfilled, but you have a secondary request, which was also mentioned in this issue but which has not yet been fulfilled. If this is correct, then I suggest updating the title of this issue to reflect the unfulfilled secondary request. Alternatively, we can close this issue as done, and you can open a separate issue for the unfulfilled request. |
Related (solved) issue: #8583 Hiding DVM Templates from Target choices could be implemented. I am not sure if this is a good idea. I believe the Title of this issue has to be changed as it does not reflect the request at the moment. |
Closing as completed. If anyone believes this issue is not yet completed, or if anyone is still affected by this issue, please leave a comment, and we'll be happy to reopen it. Thank you. |
Why wouldn't this be a good idea? It reduces the risk of a user accidentally "tainting" a DVM template with data that he explicitly wants to use in a DVM. I cannot think of a scenario it would be a bad idea. Maybe the dialog could have a checkbox "hide DVM templates" so it would be clear to any user (not only the one that configured the system). Or if it is considered a bad idea in general (like connecting templates to a NetVM directly) it could have a warning next to the (in this scenario default-checked) checkbox. |
What qubes are available in the list can be configured in global config, in the "file access" tab. If you don't want to copy files to DVM templates ever, you can add a rule denying it - it won't be listed then. |
How to file a helpful issue
The problem you're addressing (if any)
The suggestions in "open in" include
Disposable VM (%template-name%), for example "Disposable VM (dvm-internet)"
if I type a filter text , e.g. "inter" this filter text does not match the Disposable VM (dvm-internet)" - and even worse: it does match the dvm template! So if I type the text of the dvm-type that I would like to use I am lead to open it in the template instead of a dvm!
The solution you'd like
The filter text should match the template name as well. I think there is no way that it makes sense that it does not. Furthermore it may be worth considering, that "open in" does hide all dvm templates (and only show dvm instances)
The value to a user, and who that user might be
Possible intoxication/compromising of a dispVM-template would be avoided.
The text was updated successfully, but these errors were encountered: