Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods version of the podspec file IS NOT up to date with the current version on GitHub #561

Closed
soberman opened this issue Jul 5, 2018 · 5 comments

Comments

@soberman
Copy link

soberman commented Jul 5, 2018

I have read CONTRIBUTING and have done my best to follow them.

What did you do?

Updated podfiles and tried to run to the project under the Xcode 10

What did you expect to happen?

Nimble.podspec file to include s.swift_version = '4.0'

What actually happened instead?

Nimble.podspec file doesn't include s.swift_version = '4.0'.
A s a result default Swift version 4.2 is being used and I get the compiler error: 'defaultRunLoopMode' has been renamed to 'RunLoop.Mode.default'.

Environment

List the software versions you're using:

  • Quick: 1.2.0
  • Nimble: 7.1.2
  • Xcode Version: 10.0 beta 2 (10L177m)
  • Swift Version: 4.2
  • Cocoapods: 1.5.3
@ikesyo
Copy link
Member

ikesyo commented Jul 5, 2018

That is alreasy addrssed in #549 and #554. You can use 7.x-branch for now and we will have a new 7.x release in a few days.

@ikesyo ikesyo closed this as completed Jul 5, 2018
@fabb
Copy link

fabb commented Jul 5, 2018

But this issue does not need a new release, it just needs pushing the correct podspec to the Cocoapods spec repo.

@ikesyo
Copy link
Member

ikesyo commented Jul 5, 2018

the correct podspec

The current podspec is not wrong, it's correct as is.

Nimble v7 is compatible with both Swift 3 and Swift 4 so it isn't necessary to add swift_version (but we'll use the functionality in Nimble v8 in a future). And also altering already published podspecs will not be good habit (or may not be possible with today's CocoaPods trunk).

@fabb
Copy link

fabb commented Jul 5, 2018

Ok, good point. I‘ll just override the swift version build setting in my Podfile post_install until the changes you mentioned get released.

@ikesyo
Copy link
Member

ikesyo commented Jul 7, 2018

v7.1.3 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants