Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DispatchTimeInterval for interval configurations #694

Closed
ikesyo opened this issue Sep 17, 2019 · 4 comments
Closed

Use DispatchTimeInterval for interval configurations #694

ikesyo opened this issue Sep 17, 2019 · 4 comments
Milestone

Comments

@ikesyo
Copy link
Member

ikesyo commented Sep 17, 2019

It would provide more descriptive APIs and type safety.

// before
expect(...).toEventually(equal(...), timeout: 0.1)
waitUntil(timeout: 1) { done in ... }

// after
expect(...).toEventually(equal(...), timeout: .milliseconds(100))
waitUntil(timeout: .seconds(1)) { done in ... }
@ikesyo ikesyo added this to the v9.0.0 milestone Sep 30, 2019
@ikesyo ikesyo modified the milestones: v9.0.0, v10 Feb 22, 2020
@ikesyo ikesyo modified the milestones: v10, v9.0.0 May 3, 2020
@ikesyo
Copy link
Member Author

ikesyo commented May 3, 2020

Closed by #718.

@NicholasTD07
Copy link

Long time user of the Quick and Nimble framework since Swift 1.0, I think. Really appreciate all the work you have been doing!

May I ask why this change happened? Without any description or context, it's hard to understand what's the benefit of this change. I have recently upgraded to Nimble, v9.0.0. I am pretty sure I am not the only one who got a lot of broken tests due to this change.

@ikesyo
Copy link
Member Author

ikesyo commented Oct 14, 2020

@NicholasTD07 Sorry for the inconvenience. I've just updated this issue's description.

@NicholasTD07
Copy link

@ikesyo Thanks! Yeah, it definitely help with type safety and also a clearer API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants