-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: explicitly allow multiple versions #83
Comments
I quite like |
I tried to fork the repo and give it a go although I have never written Rust so I didn't get very far 😂 If it ever gets picked up I am happy to help with testing or anything like that! |
Same idea but updated a bit to avoid creating a new option by re-using the Let me know if that looks good to you! |
It looks good, shall we close this one? |
We have different apps on different versions of next and react. We use peer dependencies to ensure that a package can be installed on an app, which works well for us. That means that maybe package-b is using react 18, but doesn't support react 17. so app-a on react 17 can't use package-b yet.
We'd love to allow specific versions of react, or set allow max 2 different versions.
Based on clarity and common conventions, I propose using --allow for specifying allowed versions and --max for specifying the maximum number of versions allowed.
and
To be honest, the second idea I don't really like. I favour the first, "allow", option. Although I just had to spitball the idea of having a "max" flag too.
The text was updated successfully, but these errors were encountered: