Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding !<package> will make all the child folders ignored by sherif #90

Closed
baptisteArno opened this issue Aug 22, 2024 · 1 comment · Fixed by #91
Closed

Adding !<package> will make all the child folders ignored by sherif #90

baptisteArno opened this issue Aug 22, 2024 · 1 comment · Fixed by #91
Labels
bug Something isn't working

Comments

@baptisteArno
Copy link
Contributor

          This behavior is expected, as any folder in e.g. `apps/*` is considered a package. We could (and maybe should) ignore `.npm` folders though, and for `packages/ui` you should update your `workspaces` configuration to add `!packages/ui`

Originally posted by @QuiiBz in #86 (comment)

On my repo: https://github.com/baptisteArno/typebot.io

If I run sherif as is, it will say that openai package has different versions accross the repo.

As soon as I add !packages/forge to my package json workspaces list, the error disappear which makes me think that forge/blocks/openai package is then ignored because of that

@baptisteArno baptisteArno changed the title Adding !<package> will make all the folder children ignored by sherif Adding !<package> will make all the child folders ignored by sherif Aug 22, 2024
@QuiiBz QuiiBz added the bug Something isn't working label Aug 22, 2024
@QuiiBz
Copy link
Owner

QuiiBz commented Aug 31, 2024

Now released in https://github.com/QuiiBz/sherif/releases/tag/v1.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants