Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TranslatableComponent#visitors is misnamed #494

Open
Antikyth opened this issue Sep 11, 2023 · 0 comments
Open

TranslatableComponent#visitors is misnamed #494

Antikyth opened this issue Sep 11, 2023 · 0 comments
Labels
s: tiny PRs with less than 50 lines t: refactor proposes a refactor

Comments

@Antikyth
Copy link
Contributor

This is not a list of visitors, but rather a List<StringVisitable> representing the different "parts" of the text component.

Say the component's text after translation is Hello, %s! and it is given an argument world with which to format. This "visitors" list would be:

  • Hello,
  • world`
  • !

Visitable != visitor.
@Antikyth Antikyth changed the title TranslatableComponent.visitors is misnamed TranslatableComponent#visitors is misnamed Sep 11, 2023
@ix0rai ix0rai added t: refactor proposes a refactor s: tiny PRs with less than 50 lines labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s: tiny PRs with less than 50 lines t: refactor proposes a refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ix0rai @Antikyth