Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential hard-locking for Tracked Data Handlers #385

Open
OroArmor opened this issue Aug 26, 2024 · 1 comment
Open

Potential hard-locking for Tracked Data Handlers #385

OroArmor opened this issue Aug 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers library: entity Related to the entity library.

Comments

@OroArmor
Copy link
Member

Describe the bug

A combination of mixin ordering (we are added after another mod) plus the mod causing the issue not being the development mod could hard lock a game by crashing on startup.

In addition, if a mod injects at the top of <clinit> and registers null, we then believe that is the BYTE handler, causing another crash.

How did QSL break?

if (!quilt$pastStaticInit && QuiltLoader.isDevelopmentEnvironment()) {
throw new RuntimeException("Unnamed TrackedDataHandler added before static initialize completed. This either means that a new TrackedDataHandler was added by Minecraft, or a mod injected into a poor place.");
}

Which environment did you encounter this bug in?

Both

Logs

No response

@OroArmor OroArmor added bug Something isn't working good first issue Good for newcomers library: entity Related to the entity library. labels Aug 26, 2024
@OroArmor OroArmor self-assigned this Aug 26, 2024
@QuiltMC QuiltMC deleted a comment Aug 26, 2024
@QuiltMC QuiltMC deleted a comment Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers library: entity Related to the entity library.
Projects
None yet
Development

No branches or pull requests

2 participants
@OroArmor and others