Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove passing option object passing to baw-api.service methods #2166

Open
hudson-newey opened this issue Nov 11, 2024 · 0 comments
Open

Remove passing option object passing to baw-api.service methods #2166

hudson-newey opened this issue Nov 11, 2024 · 0 comments
Labels
architecture Architectural changes to the software

Comments

@hudson-newey
Copy link
Member

At the moment our baw-api.service methods allow passing in a BawOptions object that allows us to disable error message, disable caching, and disable sending authentication information.

This is an incorrect fix, and we should instead create the service with the correct options (perhaps through a provider factory)

@hudson-newey hudson-newey added the architecture Architectural changes to the software label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural changes to the software
Projects
None yet
Development

No branches or pull requests

1 participant