Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved grouping of menu items #2182

Open
hudson-newey opened this issue Dec 4, 2024 · 0 comments
Open

Improved grouping of menu items #2182

hudson-newey opened this issue Dec 4, 2024 · 0 comments
Assignees
Labels
architecture Architectural changes to the software enhancement New feature or request

Comments

@hudson-newey
Copy link
Member

hudson-newey commented Dec 4, 2024

At the moment our menu items automatically sort based on menu item type (e.g. link, modal or action), parents, an order attribute, and alphabetical value.

This automatic ordering system was supposed to save us time when adding new menu items.

However, this automatic ordering system has proved to be a burden to maintain since if a menu item doesn't end up where we want it to, we have to create a new programmatic algorithm to automatically re-order the menu items.

E.g. at the moment, the project menu items have no discernible category grouping

image

While we could re-adjust the algorithm to take categories into account, we should just order the menu items based on the order they are seen in the definition.

export const projectMenuItemActions = [
visualizeMenuItem,
editProjectMenuItem,
editProjectPermissionsMenuItem,
deleteProjectModal,
newSiteMenuItem,
assignSiteMenuItem,
projectAnnotationsModal,
audioRecordingMenuItems.list.project,
audioRecordingMenuItems.batch.project,
harvestsMenuItem,
reportMenuItems.new.project,
annotationMenuItems.search.project,
];

This issue supersedes: #112

@hudson-newey hudson-newey added enhancement New feature or request architecture Architectural changes to the software labels Dec 4, 2024
@hudson-newey hudson-newey self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural changes to the software enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant