Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standard-sized GPT linux disk image #73

Open
oldgalileo opened this issue Sep 5, 2021 · 0 comments
Open

Create standard-sized GPT linux disk image #73

oldgalileo opened this issue Sep 5, 2021 · 0 comments

Comments

@oldgalileo
Copy link
Contributor

The current disk image included in the test fixtures has a size (in blocks) of 29. This was due to an error where the block bounds of the partition were not treated as inclusive. With this error in mind, the image was created with a first LBA of 34 and a last LBA of 64 (inclusive), for a total length of 29.

This should likely be updated to have a first LBA of 34 and a final LBA of 29, or for even more rigorous adherence to best practices a first LBA of 2048 for 1MiB alignment (at the very least, it should be 4k aligned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant