Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[✨] Allow to use native fetch in browser #5808

Closed
ziimakc opened this issue Feb 1, 2024 · 1 comment
Closed

[✨] Allow to use native fetch in browser #5808

ziimakc opened this issue Feb 1, 2024 · 1 comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request

Comments

@ziimakc
Copy link

ziimakc commented Feb 1, 2024 •
edited
Loading

Is your feature request related to a problem?

I would like to avoid downloading 2.6mb undici in browser while native fetch is available there.

(https://site.test/@fs/home/me/apps/test/node_modules/.pnpm/@builder.io+qwik@1.4.3_@types+node@20.11.16_undici@6.6.0/node_modules/@builder.io/qwik/core.mjs?v=b666f2aa)

Describe the solution you'd like

Add a configuration option to use native fetch if targeting modern browser.
@ziimakc ziimakc added STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request labels Feb 1, 2024
@wmertens
Copy link
Member

wmertens commented Feb 1, 2024

Solved by #5702 but we didn't merge yet because it's a breaking change in node versions.

However I learned today that node 16 doesn't even work :)

@ziimakc ziimakc closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmertens @ziimakc