[🐞] server$ middleware cannot catch errors

[DustinJSilk]

Which component is affected?

Qwik City (routing)

Describe the bug

Middleware in a plugin file is able to intercept and catch routeLoader$ errors, but server$ can only call next() but catching errors doesn't work - the error is always returned immediately to the browser.

The usecase for this is to catch specific network errors (in this case ConnectErrors from connectrpc) and convert them into ServerErrors to return the correct status codes, and also to log errors with structured logging.

For example:

import { type RequestHandler } from "@builder.io/qwik-city";

export const onRequest: RequestHandler = async ({ url, next }) => {
  const isServer = url.search.startsWith("?qfunc=");

  if (isServer) {
    console.log("server$ middleware triggerd");
  } else {
    console.log("routeLoader$ middleware triggerd");
  }

  try {
    await next();
  } catch (err) {
    if (isServer) {
      // <------------------------ This never runs ------------------->
      console.log("caught server$ error");
    } else {
      console.log("caught routeLoader$ error");
    }
  }
};

Reproduction

https://github.com/DustinJSilk/qwik-server-middleware-error/tree/main

Steps to reproduce

Run the app and view errors in the terminal

System Info

N/A

Additional Information

No response