Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epidemiological weeks #16

Open
zjfspz opened this issue Jan 7, 2022 · 12 comments
Open

Epidemiological weeks #16

zjfspz opened this issue Jan 7, 2022 · 12 comments

Comments

@zjfspz
Copy link

zjfspz commented Jan 7, 2022

Would it be possible to be make it possible to add a epidemiological week number of the year for each week?
(suggestion: i use lubridate::epiweek in my codes)

I'm looking for something similar to this epidemiological calendar:
https://vigilancia.ispch.gob.cl/app_direct/varcovid/#shiny-tab-cal_epi

@mschilli87
Copy link

mschilli87 commented Jan 8, 2022

As of now, calendR hardcodes %W for the week numbers. Sure it would be possible to change that.
In case @R-CoderDotCom is not interested in adding this feature (e.g. to not pull in lubridate as additional dependency): I am working on a fork of calendR (still awaiting some clarification of the licensing before publishing it) and would be willing to add this in. Expect a couple of weeks to pass though before I can get to it myself.

@mschilli87
Copy link

FWIW I just realized calendR already depends on lubridate (via suncalc), so I see no reason not to add this.

@zjfspz
Copy link
Author

zjfspz commented Jan 10, 2022

Great!
When do you think it is possible to make that update?

@mschilli87
Copy link

@zjfspz: It's really hard to make an estimate since I have very little spare time right now.
I would say January is very unlikely, but maybe February. I am sorry I won't get it to it sooner. It's not a big change but there are many things want to get done before this. 😉

@zjfspz
Copy link
Author

zjfspz commented Feb 14, 2022

Hello again!

I was passing by to ask if you had time to look at this thread. In any case, thank you very much for considering my request.

Greetings!

@mschilli87
Copy link

@zjfspz: Sorry, work at my day job got even more tense than anticipated. I really hope to get to working on my fork in the next couple of weeks. This is definitely high on my to-do list. But thanks for reminding me. It's good to know that there is still interest. Apologies for the delay.

@mschilli87
Copy link

@zjfspz: Would a new parameter week.number.style with default options "default", "iso", and "epi" work for your use case? I don't want to add this directly to week.number to keep backwards compatibility with the TRUE/FALSE flag used right now.
If you have a better suggestion, please let me know soon as I'm about to start working on this.

@zjfspz
Copy link
Author

zjfspz commented Mar 10, 2022

I think it would work perfect.
Great, I'm waiting for your results.
Greetings,

@mschilli87
Copy link

mschilli87 commented Mar 23, 2022

@zjfspz: I did find some time to work on my fork and hope to get to this over the coming weekend. So if all goes well, this could land on CRAN before the end of the month.

@zjfspz
Copy link
Author

zjfspz commented Mar 25, 2022

Excellent! I will be attentive to your confirmation to test the new function
Thank you

@zjfspz
Copy link
Author

zjfspz commented Jun 8, 2022

@R-CoderDotCom Did you make progress with this?

@mschilli87
Copy link

@zjfspz: I made a lot of progress on my fork in March but since then I did not have time to work after my dayjob. I still plan on getting back to this, hopefully in summer, and will post here once I finally get it done. Apologies for the slow progress but sometimes life gets in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants