Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tables from a chart share id #3

Open
AleksueiR opened this issue Dec 14, 2017 · 2 comments
Open

Multiple tables from a chart share id #3

AleksueiR opened this issue Dec 14, 2017 · 2 comments
Labels

Comments

@AleksueiR
Copy link
Member

AleksueiR commented Dec 14, 2017

When several tables are rendered from a single chart, their ids are the same. Not only this is not valid HTML, but the WET table parser refuses to parse such tables._

@AleksueiR AleksueiR added the bug label Jan 4, 2018
@AleksueiR
Copy link
Member Author

Is this even a valid use case - to render multiple tables for a single chart?

@AleksueiR
Copy link
Member Author

The id of the table is linked to the id of the chart here: https://github.com/highcharts/highcharts/blob/0c4f54a6b3d5f5c89ae47d8c5f7146a6d315d6e4/js/modules/screen-reader.src.js#L711

There are also some accessibility features relying on that id value, and it doesn't look that's it easy to change that id.

We can disallow multiple instances of the same chart table as a "solution" here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant