Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawning ID card and PDA is easily breakable and kicks client when it happens #1136

Closed
stilnat opened this issue Mar 23, 2023 · 1 comment
Closed
Labels
Bounty Tasks with a monetary reward. Bounty: 40 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. Bug: Confirmed Bugs that have been confirmed by another contributor. High Priority Life or death people, lets go! Role everything related to roles

Comments

@stilnat
Copy link
Contributor

stilnat commented Mar 23, 2023

Summary

While messing around with adding items, I had to reload the asset database, and I spawned with some cans in my inventory instead of the pda and id card.

Current Behavior

Currently, pda and idcard are references in the RoleData scriptable object, and must be set in editor. The issue with that is, it doesn't update when modifying the asset database, it therefore points to another item, different from the one intended.
This can lead to client or even host being kicked and producing a hard error to understand, that's why I consider fixing this high priority. In general, avoid storing a given value of an itemId or any other Id from other databases, those ids are bound to change constantly.

Steps to Reproduce

  • modify position of pda and id card prefabs in the addressable groups
  • go into content/data and on the items scriptable object click load assets from addressable groups.
  • see that the items in inventory are not what is expected.
@stilnat stilnat added Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. Role everything related to roles labels Mar 23, 2023
@stilnat stilnat added the High Priority Life or death people, lets go! label Mar 23, 2023
@stilnat stilnat removed this from the 0.0.7 - Fixing, Cleaning, Testing milestone Apr 25, 2023
@stilnat stilnat moved this from 📋 Backlog to 📯 Sprint in 0.0.7 - Fixing, Cleaning, Testing Sep 4, 2023
@cosmiccoincidence cosmiccoincidence moved this from 📯 Sprint to 📋 Backlog in 0.0.7 - Fixing, Cleaning, Testing Sep 4, 2023
@stilnat stilnat added Bounty: 10 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. Bug: Confirmed Bugs that have been confirmed by another contributor. Bounty Tasks with a monetary reward. and removed Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. labels Sep 11, 2023
@stilnat stilnat added Bounty: 20 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. Bounty: 40 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. and removed Bounty: 10 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. Bounty: 20 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. labels Dec 12, 2023
@stilnat
Copy link
Contributor Author

stilnat commented Dec 14, 2023

closed via #1268. Value of bounty reestimated to 40 dollars as a major system rewrite was necessary to properly solve the issue

@stilnat stilnat closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Tasks with a monetary reward. Bounty: 40 dollars 💰 Value of the bounty. Do not put this tag without the bounty tag. Bug: Confirmed Bugs that have been confirmed by another contributor. High Priority Life or death people, lets go! Role everything related to roles
Projects
No open projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant