Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent line endings in files #1262

Closed
stilnat opened this issue Sep 20, 2023 · 0 comments · Fixed by #1265
Closed

Inconsistent line endings in files #1262

stilnat opened this issue Sep 20, 2023 · 0 comments · Fixed by #1265
Labels
Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: medium 🥼 For those that already have some understanding of the code base. General Management Clean up or other management tasks.

Comments

@stilnat
Copy link
Contributor

stilnat commented Sep 20, 2023

Summary

We have this issue, most noticable when using Github desktop, that many files appear modified when there's actually zero changes on them.

This thread on github is helpful to understand the issue desktop/desktop#14616,
and a solution is provided :
https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

implement the solution correctly so that we don't get any unwanted false changes on Github desktop.
The better solution is probably using the .gitattributes, but be careful about adding exhaustively all type of files that are not text and that should not be changed, such as .fbx, .jpg ...

@stilnat stilnat added Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: medium 🥼 For those that already have some understanding of the code base. General Management Clean up or other management tasks. and removed Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: medium 🥼 For those that already have some understanding of the code base. General Management Clean up or other management tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant