Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run through StyleCI #82

Closed
jbrooksuk opened this issue Aug 13, 2015 · 15 comments
Closed

Run through StyleCI #82

jbrooksuk opened this issue Aug 13, 2015 · 15 comments

Comments

@jbrooksuk
Copy link
Contributor

I know currently you use Deployer-CIBot to comment on code written incorrectly about standards. How about using https://styleci.io which not only produces a patch file for you to apply, it also integrates directly into GitHub's statuses but can also open a PR containing the fixed code for you.

@vinkla
Copy link

vinkla commented Aug 13, 2015

👍

@REBELinBLUE
Copy link
Owner

Duplicate of #75

@jbrooksuk
Copy link
Contributor Author

Oh haha!

@jbrooksuk
Copy link
Contributor Author

I thought I'd opened an issue about this before :)

@REBELinBLUE
Copy link
Owner

Ha ha, no problem. I was right that I had actually tried StyleCI before, but hadn't actually looked at the documentation much so had not figured out how to change it to psr-2 which I have now done.

@jbrooksuk
Copy link
Contributor Author

Ah yes, we recently re-released the StyleCI service with extra documentation! :)

@REBELinBLUE
Copy link
Owner

Don't suppose StyleCI offers the badges in different styles does it, i.e. flat rather than flat squared

@REBELinBLUE
Copy link
Owner

i.e.
StyleCI

@jbrooksuk
Copy link
Contributor Author

Oh, not styles I'm afraid. I'll look into adding that though.

@jbrooksuk
Copy link
Contributor Author

I lied, we do; https://styleci.io/repos/33559148/shield?style=plastic

@REBELinBLUE
Copy link
Owner

Fair enough, just wondered :)

@REBELinBLUE
Copy link
Owner

ah

@jbrooksuk
Copy link
Contributor Author

Shield!

@REBELinBLUE
Copy link
Owner

Shield!

@REBELinBLUE
Copy link
Owner

Perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants